-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add math/base/special/roundnf implementation
#5853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/roundnf implementation
#5853
Conversation
|
/stdlib update-copyright-years |
|
I think this PR also has a pre requisite which is |
math/base/special/roundnf implementation
|
I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue". Why this matters: Required action: Thank you for your contribution to the project! |
|
Hi @NishchayRajput, since powf has just been merged, this PR is now unblocked! Are you planning to update this implementation to use powf? If you are busy or no longer working on this, please let me know I would be happy to pick this up and submit a fresh PR to help verify the new powf integration. |
|
@Amansingh0807 Feel free to submit a new PR. I'll go ahead and close this one out. |
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
|
@kgryte Thanks for the confirmation! I will pick this up and submit a fresh PR for |
Ref: #649.
Description
This pull request:
math/base/special/roundnfRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers