Skip to content

Conversation

@NishchayRajput
Copy link
Contributor

@NishchayRajput NishchayRajput commented Mar 7, 2025

Ref: #649.

Description

What is the purpose of this pull request?

This pull request:

  • Implementation of math/base/special/roundnf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 7, 2025
@NishchayRajput NishchayRajput marked this pull request as draft March 7, 2025 10:52
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 7, 2025
@ShabiShett07
Copy link
Contributor

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 7, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 7, 2025
@ShabiShett07
Copy link
Contributor

I think this PR also has a pre requisite which is powf. Maybe it needs to be merged first till then it can be operated using pow

@NishchayRajput NishchayRajput changed the title feat: add math/base/special/roundnf implementation feat: add math/base/special/roundnf implementation Mar 7, 2025
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@Planeshifter
Copy link
Member

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged.

Required action:
Use "Progresses:" or "Ref:" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@stdlib-bot stdlib-bot removed the Potential Duplicate There might be another pull request resolving the same issue. label Apr 19, 2025
@Amansingh0807
Copy link
Contributor

Hi @NishchayRajput, since powf has just been merged, this PR is now unblocked!

Are you planning to update this implementation to use powf? If you are busy or no longer working on this, please let me know I would be happy to pick this up and submit a fresh PR to help verify the new powf integration.

@kgryte
Copy link
Member

kgryte commented Dec 9, 2025

@Amansingh0807 Feel free to submit a new PR. I'll go ahead and close this one out.

@kgryte kgryte added the autoclose: Stale Pull request which should be auto-closed as considered stale. label Dec 9, 2025
@stdlib-bot
Copy link
Contributor

This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one.

We appreciate your interest in contributing to stdlib!

@stdlib-bot stdlib-bot closed this Dec 9, 2025
@Amansingh0807
Copy link
Contributor

@kgryte Thanks for the confirmation!

I will pick this up and submit a fresh PR for roundnf, ensuring it properly utilizes the newly merged powf and follows the current project standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Stale Pull request which should be auto-closed as considered stale. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants